Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#408] Improve error messages #410

Merged
merged 9 commits into from
Dec 27, 2021
Merged

[#408] Improve error messages #410

merged 9 commits into from
Dec 27, 2021

Conversation

Decipher
Copy link
Member

@Decipher Decipher commented Dec 22, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Added error handling to DruxtClient
  • Added error handling to DruxtModule

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Screenshots/Media:

@Decipher Decipher added the enhancement New feature or request label Dec 22, 2021
@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2021

🦋 Changeset detected

Latest commit: befb12d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
druxt-entity Minor
druxt Minor
druxt-router Minor
druxt-blocks Patch
druxt-site Patch
druxt-views Patch
druxt-breadcrumb Patch
druxt-menu Patch
druxt-schema Patch
druxt-test-utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Decipher Decipher force-pushed the feature/408-error_messages branch from 43be9ac to 5e8b2c0 Compare December 23, 2021 21:28
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #410 (befb12d) into develop (dc226c2) will decrease coverage by 0.07%.
The diff coverage is 93.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #410      +/-   ##
===========================================
- Coverage    96.93%   96.85%   -0.08%     
===========================================
  Files           88       88              
  Lines         2869     2897      +28     
  Branches       621      625       +4     
===========================================
+ Hits          2781     2806      +25     
- Misses          80       83       +3     
  Partials         8        8              
Impacted Files Coverage Δ
packages/router/src/router.js 100.00% <ø> (ø)
packages/druxt/src/client.js 91.22% <92.50%> (-0.78%) ⬇️
packages/druxt/src/components/DruxtModule.vue 100.00% <100.00%> (ø)
packages/entity/src/components/DruxtEntityForm.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc226c2...befb12d. Read the comment docs.

@Decipher
Copy link
Member Author

While test coverage is lower than I'd like, I don't believe theres much risk with this particular change and I'm going to merge this.

@Decipher Decipher merged commit 7b749bd into develop Dec 27, 2021
@Decipher Decipher deleted the feature/408-error_messages branch December 27, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant