Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiteAliasFileLoader isn't handling if createAliasRecordsFromSiteData doesn't find a yaml file #3354

Closed
Skarlso opened this issue Feb 5, 2018 · 0 comments

Comments

@Skarlso
Copy link

Skarlso commented Feb 5, 2018

This part of the code:

foreach ($siteData as $envName => $data) {
doesn't handle if $siteData if false. Which can be the result of a loadSiteDataFromFile.

This will result in Drush saying: site alias not found, but doesn't explain why not, leaving the user up to try and investigate the failure. And an ugly Warning message for drush site:alias like this:

 [warning] Invalid argument supplied for foreach() SiteAliasFileLoader.php:176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant