Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support site-local drush without composer #3043

Closed
AdamPS opened this issue Oct 9, 2017 · 6 comments
Closed

Support site-local drush without composer #3043

AdamPS opened this issue Oct 9, 2017 · 6 comments

Comments

@AdamPS
Copy link
Contributor

AdamPS commented Oct 9, 2017

As per this Drupal issue but perhaps it more logically belongs here.

The composer method is not yet ready for everybody, so please can we keep drush working for those using the tarball install?

All the required code is already present (I tested it). All that is needed is to provide a way for tarball users to set up their Drupal image correctly.

This could be in the form of an extra tarball that contains drush plus all dependencies not already in Drupal core. Might it be possible to build such a tarball from github please?

@weitzman
Copy link
Member

weitzman commented Oct 9, 2017

The point of a site local drush is

  1. dependencies are resolved on every update so your codebase is known to be compatible with all its dependencies
  2. drush's classes are in the same autoloader as the site

This proposal accomplishes neither goal. Wont fix.

@weitzman weitzman closed this as completed Oct 9, 2017
@AdamPS
Copy link
Contributor Author

AdamPS commented Oct 9, 2017

Thanks for the reply. Well either I didn't explain properly or I don't understand.

  1. I agree that such a drush build is tied to a particular Drupal minor version such as 8.4.x - however they come every 6 months so it's not so horrible.
  2. I had expected that the Drupal core autoloader would automatically pick up the files in the drush tar if they were dropped into the right place according to the naming convention.

I put forward some other options in the Drupal issue - e.g. there could be a drush+Drupal image built either here or on drupal.org. I would be very happy to hear any alternative solutions from a drush expert.

At the moment composer is not officially adopted into Drupal so please don't abandon users who have valid reasons for not using composer yet.

@greg-1-anderson
Copy link
Member

greg-1-anderson commented Oct 9, 2017

I'm not sure what the ask is here. You want to put the drush.phar in __ROOT__/drush/drush.phar? Why is this better than putting the global Drush 8 on your $PATH?

@AdamPS
Copy link
Contributor Author

AdamPS commented Oct 9, 2017

Apologies, I'm not explaining it very well. As I understand it, the drush 8 phar uses symfony 2 and this is a headache for Drupal 8.4+

I propose to build a drush 8 tar that is specifically targetted to match the dependencies of the relevant Drupal version.

Or maybe even simpler to build a tar with the latest version of both drush and Drupal.

@greg-1-anderson
Copy link
Member

@AdamPS We already considered and rejected the idea of having multiple phars with different dependencies. Note that the current global Drush 8 phar with Symfony 2 happens to work with Drupal 8.4.0 (because Symfony 2 and Symfony 3 are fairly similar).

The issue for further improvements on this subject that you should follow is #2787.

@AdamPS
Copy link
Contributor Author

AdamPS commented Oct 9, 2017

OK, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants