Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-issue for various pm related fixes #2438

Closed
AdamPS opened this issue Nov 8, 2016 · 2 comments
Closed

Meta-issue for various pm related fixes #2438

AdamPS opened this issue Nov 8, 2016 · 2 comments

Comments

@AdamPS
Copy link
Contributor

AdamPS commented Nov 8, 2016

I hope this issue will help everyone get a clear shared understand of the future of drush and pm.

Pulling together what I have learnt from reading other issues:

There are various pm issues still open. I appreciate the maintainers don't want to spend time fixing them. However I have written patches in a couple of PRs that contain fixes. Is there any chance please that the maintainers would consider at least taking the time to review and merge pm fixes? D7 still has quite a few years of life left in it. Secondary question: some of my fixes include removal of redundant outdated code - is this tidy up useful, or would you prefer minimal safer patches?

At the moment, how does anyone using drush pm know that it is deprecated and composer is preferred? Can we add to the help text of pm-updatecode - especially if running D8? If PRs for pm are no longer accepted except for high severity, please can we try to communicate this as clearly as possible? Another thing we can do is to comment in all the outstanding issues to inform people not to waste their time creating a PR.

Thanks!

@AdamPS
Copy link
Contributor Author

AdamPS commented Feb 10, 2017

For anyone reading this thread: drush pm is dying. The maintainers no longer want to make fixes, and eventually will remove support entirely. Composer is the way forward and @weitzman states in #2275:

I'll note that sites built with https://github.com/drupal-composer/drupal-project dont suffer from this problem, mainly because the dont use pm-updatecode. Thats how all D8+ sites should be built and even D7 sites should consider it.

I have added comments on several outstanding pm issues to discourage anyone from putting forward a PR. I have closed my own issues and PRs for pm.

In drush 8.x, drush pm is usable provided you stick to the default options:

  • --version-control=backup
    
  • There is a backup (i.e. not --no-backup)
    

@AdamPS AdamPS closed this as completed Feb 10, 2017
@weitzman
Copy link
Member

Only small parts of pm are being deprecated. Namely, update code and dl. Those are code assembly functions better handled by Composer. Lot of pm like enable/uninstall/updatestatus/info/list will carry on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants