Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholders silently leak into CSS output when compiled using libsass #110

Closed
digitaljhelms opened this issue May 2, 2014 · 2 comments
Closed
Milestone

Comments

@digitaljhelms
Copy link

Compiling with sass/libsass@1122ead via sindresorhus/grunt-sass@98d808f (v0.12.1), which uses sass/node-sass@3a5607f (0.8.6) for bindings, produces undesired/invalid CSS output due to an issue when using placeholders within media queries: sass/libsass#316

Until the issue with libsass is resolved, css-modal, when digested into a project using Bower to be used with Sass, will strictly require Ruby Sass for compilation, which may make its application no longer feasible for some (like myself). The only possible stopgap measure for the time being is to use the compiled CSS output from the build/ directory instead of the Sass source.

However, it's worth noting that even though #83 and #95 are closed (which address adding the build/ directory to the Bower package) and v1.1.0alpha is in the wild, Bower is still referencing v1.0.4 as the latest release, I assume because:

  1. "v1.1.0alpha" is not a valid semver version for a pre-release since it does not include a hyphen immediately following the patch version between the identifier
  2. when using tilde operators, as Bower defaults to, a prerelease of the next significant digit will NOT be satisfactory, so v1.1.0-alpha will not satisfy ~1.0.4

To get the CSS output in the build/ directory when using Bower, you must pass the "v1.1.0alpha" version identifier to the install command explicitly:
bower install css-modal#v1.1.0alpha --save-dev

Although the primary issue I'm reporting here isn't with css-modal specifically, I felt it prudent to at least document my findings while trying to use css-modal with libsass. I hope this helps anyone else who might be scratching their head like I was.

@anselmh
Copy link
Contributor

anselmh commented May 6, 2014

Hi, thanks for the great feedback. We’ll have a look at it and will definitely try to fix all the issues occurring with libsass. Until now, css-modal does not support libsass officially, but it’s a goal to support it. Any Pull Request fixing some of the issues is greatly appreciated by the way.

@drublic drublic added this to the v1.2.0 milestone May 22, 2014
@drublic
Copy link
Owner

drublic commented Oct 12, 2014

@digitaljhelms I think this was a bug with libsass for quite some time now. They fixed it with version 3.0 which has a (couple of) RC at the moment.
Please try the version and let us know if your issue isn't fixed yet. I will definitely look into this now.

Concerning versioning: This was a major failure by myself. We will switch to more semantic versions from now one. You will get the latest release which is 1.1.8 from bower since a couple of weeks.

@drublic drublic closed this as completed Oct 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants