Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking environment #84

Open
loeffel-io opened this issue Jul 20, 2022 · 8 comments
Open

Breaking environment #84

loeffel-io opened this issue Jul 20, 2022 · 8 comments

Comments

@loeffel-io
Copy link
Contributor

Upgrading to 0.5.0 (commit f058f76) is breaking our whole system with drone chart 0.4.0 and droner-runner-kube chart 0.1.9

the drone-runner-kube can't ping the remote server anymore

@kameshsampath
Copy link
Contributor

kameshsampath commented Jul 20, 2022

Hi @loeffel-io ,

Can you try updating your drone values.yaml to be have service like

service:
  type: ClusterIP
  port: 80

or you can update drone-runner-kube chart values to be like

DRONE_RPC_HOST: "drone:8080"

NOTE: Having to expose port 80 in many cases require extra privileges hence it was changed from 80 to 8080.

Let me know if this helps.

@loeffel-io
Copy link
Contributor Author

loeffel-io commented Jul 20, 2022

Thanks for the answer - i will try that soon!

This breaking change should need more communication imo

@jimsheldon
Copy link
Contributor

@loeffel-io apologies for the impact this has caused you. Were you on 0.4.0 of the drone chart previously? Is that version still working ok for you? There was an issue where the 0.4.0 chart might have had this same problem briefly, I just want to verify that 0.4.0 does not have this problem.

I agree that this change should have more communication. We need to create a proper changelog along with releases where we can better highlight breaking changes like this.

@keliansb
Copy link

I'm facing the same issue after updating chart from 0.4.0 to 0.5.0. From runner pod I can see the following error :

cannot ping the remote server" error="Post \"http://drone/rpc/v2/ping\": dial tcp 10.21.30.202:80: i/o timeout

I tried your workarounds @kameshsampath and both work.

@loeffel-io
Copy link
Contributor Author

@loeffel-io apologies for the impact this has caused you. Were you on 0.4.0 of the drone chart previously? Is that version still working ok for you? There was an issue where the 0.4.0 chart might have had this same problem briefly, I just want to verify that 0.4.0 does not have this problem.

I agree that this change should have more communication. We need to create a proper changelog along with releases where we can better highlight breaking changes like this.

i think it was 0.2.5 to 0.4.0/0.5.0

@kameshsampath
Copy link
Contributor

Sorry for the inconvenience it was mainly the default port that we changed in the release from default 80 to 8080 for helping users to run with lesser privileges.

@jimsheldon - shall we update the release notes to help users upgrade with this gotcha ?

@AdamFerguson
Copy link

Just ran into this issue. Changing this env var for the runner resolved:

DRONE_RPC_HOST: "drone:8080"

Definitely think the defaults for the charts should match up.

@jimsheldon
Copy link
Contributor

We should align this with #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants