-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking environment #84
Comments
Hi @loeffel-io , Can you try updating your service:
type: ClusterIP
port: 80 or you can update DRONE_RPC_HOST: "drone:8080" NOTE: Having to expose port Let me know if this helps. |
Thanks for the answer - i will try that soon! This breaking change should need more communication imo |
@loeffel-io apologies for the impact this has caused you. Were you on 0.4.0 of the drone chart previously? Is that version still working ok for you? There was an issue where the 0.4.0 chart might have had this same problem briefly, I just want to verify that 0.4.0 does not have this problem. I agree that this change should have more communication. We need to create a proper changelog along with releases where we can better highlight breaking changes like this. |
I'm facing the same issue after updating chart from 0.4.0 to 0.5.0. From runner pod I can see the following error :
I tried your workarounds @kameshsampath and both work. |
i think it was |
Sorry for the inconvenience it was mainly the default port that we changed in the release from default @jimsheldon - shall we update the release notes to help users upgrade with this gotcha ? |
Just ran into this issue. Changing this env var for the runner resolved:
Definitely think the defaults for the charts should match up. |
We should align this with #37 |
Upgrading to
0.5.0
(commit f058f76) is breaking our whole system with drone chart0.4.0
and droner-runner-kube chart0.1.9
the drone-runner-kube can't ping the remote server anymore
The text was updated successfully, but these errors were encountered: