Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Lint #277

Open
chepsi opened this issue Mar 25, 2024 · 9 comments
Open

Enhance Lint #277

chepsi opened this issue Mar 25, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@chepsi
Copy link
Contributor

chepsi commented Mar 25, 2024

Lint is complaining a lot. We need to update it and fix the warnings and errors.
running ./gradlew ktlintCheck will highlight the issues and ./gradlew ktlintFormat will autofix some issues. we still might need to manually fix others.

@chepsi chepsi added the enhancement New feature or request label Mar 25, 2024
@Raynafs
Copy link
Contributor

Raynafs commented Mar 27, 2024

Hey @chepsi. Willing to take this. Can I also implement spotless?

@chepsi
Copy link
Contributor Author

chepsi commented Mar 27, 2024

@Raynafs Yes, you can work on this. I am pretty sure spotless is already implemented. You can check if that is the case. I have assigned the issue to you.

@Raynafs
Copy link
Contributor

Raynafs commented Mar 31, 2024

Hi @chepsi after running ./gradlew ktlintCheck it builds successfully. Not sure if something changed

@chepsi
Copy link
Contributor Author

chepsi commented May 6, 2024

@Raynafs What about the warnings?

@Raynafs
Copy link
Contributor

Raynafs commented May 14, 2024

Do you mean the general warnings in different files of the project? @chepsi

@Raynafs
Copy link
Contributor

Raynafs commented May 31, 2024

Hi @chepsi I am facing an issue with the ktlint format. I'm not sure if that's what you meant when dealing with this project.

The checks fail in the ci even when they are passing locally. Is that what you meant?

@chepsi
Copy link
Contributor Author

chepsi commented May 31, 2024

@Raynafs working on resolving it.. I'll let you know once ready.

@chepsi
Copy link
Contributor Author

chepsi commented Jun 10, 2024

@Raynafs the CI is working properly now.

@Raynafs
Copy link
Contributor

Raynafs commented Jun 10, 2024

Hi @chepsi. Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants