fix(bug): fix bug where footer not attached to keyboard in some device and update flutter_keyboard_visibility
#35
+89
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update _bottomInset and _animationBegin using didChangeMetrics method
use value notifier to update dynamic data of bottom inset and animation begin
ryanaidilp
commented
Apr 5, 2024
There was a problem hiding this comment.
This class encapsulates bottomInset and animationBegin, allowing these properties to be bundled together. By encapsulating them within this class, we facilitate their use in a ValueNotifier, promoting a cleaner and more efficient way to manage and react to changes in these values.
Example:
ValueNotifier<KeyboardAnimationData> _keyboardAnimationDataNotifier = ValueNotifier(const KeyboardAnimationData());This approach simplifies the tracking of keyboard animation data changes, enabling more responsive and straightforward UI updates.
|
Please kindly review @drogel |
|
@drogel Can you check it please? |
|
Hello @drogel - would appreciate a review, merge and release of this (thanks @ryanaidilp for the change). Our app is stuck on some other dependencies because of this version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR introduces several enhancements and bug fixes to the
keyboard_attachablepackage, significantly improving its reliability and functionality across different devices and scenarios. Here are the key changes:Enhancements:
analysis_options.yamlto streamline code analysis and ensure consistency with Flutter's recommended linter rules.flutter_keyboard_visibilitypackage from version5.4.1to6.0.0. This update embraces the latest improvements and fixes fromflutter_keyboard_visibility, ensuring better keyboard visibility handling. (Should resolve Update flutter_keyboard_visibility to 6.0.0 #34)Bug Fixes:
KeyboardAttachable, sometimes did not attach correctly above the keyboard. This problem was due to incorrect keyboard height calculations on some devices, whereMediaQuery.of(context).viewInsets.bottomreturned0. The fix involves usingMediaQueryData.fromWindow(WidgetsBinding.instance.window)to obtain more accurate keyboard height measurements.bottomInsetandanimationBeginwithin a newKeyboardAnimationDataclass. This encapsulation promotes better data management and streamlines animation handling.WidgetBindingObservermixin and utilizeddidChangeMetricsto listen to changes in the app's metrics. This approach ensures that the_updateBottomSizeIfNeededlogic is executed promptly, adjusting the UI in response to any metrics changes, including keyboard appearance.ValueNotifierwithKeyboardAnimationDatainstead of relying solely on local variables. This change guarantees that the UI is rebuilt when there are changes to the keyboard's visibility or size, addressing issues where the UI did not update on some devices.These improvements aim to make
keyboard_attachablemore robust and versatile, providing a better developer experience and ensuring more consistent behavior across various devices.