Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Settings Menu Selector #47

Open
drofp opened this issue Oct 7, 2020 · 0 comments
Open

Refactor Settings Menu Selector #47

drofp opened this issue Oct 7, 2020 · 0 comments
Labels
cleanup Style, improper form, or just tidying up

Comments

@drofp
Copy link
Owner

drofp commented Oct 7, 2020

The menu items are currently hardcoded as integer values in settings_menu.cc here.

Enums or a list/vector/array of menu items should be considered instead. Creativity is encouraged for simplicity and readability here.
@drofp drofp added the cleanup Style, improper form, or just tidying up label Oct 7, 2020
@drofp drofp mentioned this issue Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Style, improper form, or just tidying up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drofp