Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that the ‘dynamic’ mode for query builders does not merge where calls #189

Open
piedrahitapablo opened this issue Dec 18, 2023 · 0 comments

Comments

@piedrahitapablo
Copy link

Following the discussion given here, I'm creating this issue to make the "Dynamic query building" docs more clear.

The current issue is that for some reason the first time those docs are read, it's possible that people get the impression that using $dynamic() on a query enables the possibility to make multiple calls to .where(...) that are merged automatically by drizzle.

I know the docs don't state that drizzle merges the where calls and, if you read them after knowing the actual behavior, they are clear about the intent behind the $dynamic() function, but they can be improved to make more clear that .where(...) calls will keep the same behavior regarding overriding/merging.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant