Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for with_stem #287

Closed
Gilthans opened this issue Nov 9, 2022 · 2 comments
Closed

Support for with_stem #287

Gilthans opened this issue Nov 9, 2022 · 2 comments

Comments

@Gilthans
Copy link
Contributor

Gilthans commented Nov 9, 2022

Hello!
Today we noticed cloudpathlib doesn't support with_stem which was added in python 3.9.
What's the policy on this kind of compatibility (i.e. functions that exist on only some of the supported versions of python)?
Would a PR to introduce this be accepted?
@pjbull
Copy link
Member

pjbull commented Nov 9, 2022

I'd be in favor of supporting any pathlib method that is in a released and supported version of Python. We should add a note to the AnyPath documentation that the methods you choose to use should be the ones compatible with your version of Python if you want to be cloud/local agnostic.

@Gilthans Gilthans mentioned this issue Nov 20, 2022
Merged
@pjbull
Copy link
Member

pjbull commented Oct 10, 2023

This is released as of 0.16.0, thanks @Gilthans!

@pjbull pjbull closed this as completed Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjbull @Gilthans