Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint should check that payloads can be converted to param #127

Open
nsoblath opened this issue Aug 25, 2020 · 0 comments
Open

Endpoint should check that payloads can be converted to param #127

nsoblath opened this issue Aug 25, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@nsoblath
Copy link
Member

File: endpoint.py
Class: Endpoint
Functions:

  • do_set_request()
  • do_get_request()
  • do_cmd_request()

Each of those has a line that's something like:

return a_request_message.reply(payload=scarab.to_param(result))

There's no check for whether the result object can in fact be converted to param. Instead, this should be done in a try block to catch the case in which the result cannot be converted to a python object. In that case the return message should have an error return code.

@nsoblath nsoblath added the bug Something isn't working label Aug 25, 2020
@wsmithpnnl wsmithpnnl mentioned this issue Sep 22, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant