Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button alignment in navBarwhen using menuToggle directive #8943

Closed
nakulgulati opened this issue Oct 28, 2016 · 3 comments · Fixed by #9314
Closed

Button alignment in navBarwhen using menuToggle directive #8943

nakulgulati opened this issue Oct 28, 2016 · 3 comments · Fixed by #9314
Assignees
Milestone

Comments

@nakulgulati
Copy link
Contributor

nakulgulati commented Oct 28, 2016

Button with directive [menuToggle]="menuId" is right aligned on Android and Windows platform when used inside <ion-navbar>.

Button is left aligned for all 3 platforms (iOS, Android and Windows) when menuToggle directive is used without menuId specified, but is right aligned on windows when menuId is specified as such [menuToggle]="menuId" on Android and Windows.

Steps to reproduce:

  1. Checkout menuToggle API documentation: http://ionicframework.com/docs/v2/api/components/menu/MenuToggle/

Expected Behavior
<button ion-button menuToggle>Toggle Menu</button> and <button ion-button menuToggle="menuId">Toggle Menu</button> to behave consistently and the button to be left aligned navbar.

Which Ionic Version? 2.x

@manucorporat
Copy link
Contributor

Hi @nakulgulati, I don't understand what should be the expected behavior. Can you follow the issue template provided?

@nakulgulati
Copy link
Contributor Author

Hi @manucorporat, I have updated the issue and included 'expected behavior'.

@manucorporat
Copy link
Contributor

manucorporat commented Oct 29, 2016

Thanks @nakulgulati! I added this issue to my RC2 roadmap

@manucorporat manucorporat self-assigned this Oct 29, 2016
@manucorporat manucorporat added this to the 2.0.0-rc.2 milestone Oct 29, 2016
@jgw96 jgw96 modified the milestones: 2.0.0-rc.3, 2.0.0-rc.2 Nov 1, 2016
@brandyscarney brandyscarney modified the milestone: 2.0.0-rc.3 Nov 4, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 14, 2016
@manucorporat manucorporat added this to the 2.0.0-rc.4 milestone Nov 18, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants