Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-list reorder is triggering the click event in RC0 #8362

Closed
eafif opened this issue Sep 30, 2016 · 4 comments
Closed

ion-list reorder is triggering the click event in RC0 #8362

eafif opened this issue Sep 30, 2016 · 4 comments
Assignees
Labels
needs: reply the issue needs a response from the user
Milestone

Comments

@eafif
Copy link

eafif commented Sep 30, 2016

In RC0, for an ion-list with reorder set to true, when clicking on the handle and dragging the ion-item, both the ionItemReorder and click events are being triggered.

In the example below, upon reorder, both the reorderInstructions and setInstruction are being called.

<ion-list reorder="{{reorder}}" (ionItemReorder)="reorderInstructions($event)">
    <ion-item-sliding *ngFor="let instruction of instructions">
      <button ion-item (click)="setInstruction(instruction)">
        <h2>{{instruction.title}}</h2>
      </button>
      <ion-item-options side="right" icon-left>
        <button ion-button color='danger' (click)="removeInstruction(instruction.id)">
          <ion-icon name="trash"></ion-icon>
          Remove
        </button>
      </ion-item-options>
    </ion-item-sliding>
  </ion-list>
@manucorporat
Copy link
Contributor

@eafif I can not repro.

BTW, do not use reorder="{{reorder}}", but [reorder]="reorder"

@jgw96 jgw96 added v2 needs: reply the issue needs a response from the user labels Sep 30, 2016
@eafif
Copy link
Author

eafif commented Sep 30, 2016

I started a new blank project and can replicate it. Here's a link to the project.

I also included a video (bugreport.mov) showing the behaviour.

@manucorporat
Copy link
Contributor

manucorporat commented Oct 2, 2016

@eafif thanks for the repo ! I can reproduce it!
Investigating...

@manucorporat manucorporat added this to the 2.0.0-rc.1 milestone Oct 2, 2016
@manucorporat manucorporat self-assigned this Oct 2, 2016
@manucorporat
Copy link
Contributor

@eafif fixed!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

No branches or pull requests

3 participants