Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionic2 - enhancement(events) - Unsubscribe method should be an optional parameter #8235

Closed
zakton5 opened this issue Sep 27, 2016 · 1 comment

Comments

@zakton5
Copy link
Contributor

zakton5 commented Sep 27, 2016

Short description of the problem:

Nothing major here, but currently to unsubscribe from a topic you have to write

this.events.unsubscribe('some-topic', null);

This code removes all handlers tied to event 'some-topic'. The null is required.

What behavior are you expecting?

I feel the handler parameter should be optional, yet have the same behavior as is. So I feel like the following code should be valid and still remove all handlers tied to 'some-topic'.

this.events.unsubscribe('some-topic');
@Ionitron Ionitron added the v2 label Sep 27, 2016
@MikeyBeLike
Copy link

Agreed

@jgw96 jgw96 added the feature label Sep 28, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants