Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong width of text-input for iOS (in modal) #7388

Closed
adam-sokolowski opened this issue Jul 21, 2016 · 5 comments
Closed

Wrong width of text-input for iOS (in modal) #7388

adam-sokolowski opened this issue Jul 21, 2016 · 5 comments
Assignees

Comments

@adam-sokolowski
Copy link

ionic/src/components/input/input.ios.scss

For wider screens with iOS (iPad) text-input field does not stretch to the width of parent container (fills only about a half of the width).

.text-input class width is calculated the following way:
width: calc(100% - #{$text-input-ios-margin-right} - #{$text-input-ios-margin-left});

However, the default value for $text-input-ios-margin-left is 0 - and this is actually causing the problem. Lets assume, that $text-input-ios-margin-right equals 8px.

The result is:
width: calc(100% - 8px - 0); - which is invalid property value.

Solution - replacing:
$text-input-ios-margin-left: 0 !default;
by
$text-input-ios-margin-left: 0px !default;

Expected result:
Text-input field filling all available space of parent container (minus paddings)

Ionic : 2.0.0-beta.10
Platform: iOS

@brandyscarney
Copy link
Member

Thanks for the issue! Could you paste some sample html markup that I can use to reproduce this? Thanks. 😄

@jgw96 jgw96 added the needs: reply the issue needs a response from the user label Jul 21, 2016
@adam-sokolowski adam-sokolowski changed the title Wrong width of text-input for iOS Wrong width of text-input for iOS (in modal) Jul 22, 2016
@adam-sokolowski
Copy link
Author

yes, sure . here is the plunker:
http://embed.plnkr.co/yaqTLbYZ8JtF9J7kVa7K/
ios_text_input_1

@Ionitron Ionitron removed the needs: reply the issue needs a response from the user label Jul 22, 2016
@jgw96
Copy link
Contributor

jgw96 commented Aug 9, 2016

Hello @adam-sokolowski ! Is this still an issue with beta.11? Thanks!

@jgw96 jgw96 added needs: reply the issue needs a response from the user and removed platform:ios labels Aug 9, 2016
@jgw96
Copy link
Contributor

jgw96 commented Aug 14, 2016

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

@jgw96 jgw96 closed this as completed Aug 14, 2016
@adam-sokolowski
Copy link
Author

Yes, this still an issue.

@manucorporat manucorporat reopened this Oct 3, 2016
@manucorporat manucorporat self-assigned this Oct 3, 2016
@jgw96 jgw96 removed the needs: reply the issue needs a response from the user label Oct 18, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants