Modal in 2.0.0-beta.9 no longer adds page class name to ion-page element

[jasonwaters]

The element has a class attribute with a generated classname like "user-login" if the page class is named "UserLogin". This is no longer the case for modals.

see #6606

[jgw96]

Hello, thanks for opening an issue with us! Would you be able to provide a plunker that demonstrates this issue? Thanks for using Ionic!

[jasonwaters]

Hi @jgw96, I took a closer look and here's what I found:

In [email protected], there is an ion-page element with the corresponding css classname of the javascript component. I use this to add custom styles like so:

But in beta.9, the ion-page has been replaced with ion-modal-inner. That's fine, but can we add the css classname for the javascript element to that element? That will prevent my styles from breaking all over the place.

[jgw96]

Thanks for the info! If im not thinking wrong this was part of the change when we added inset modals on bigger screens. I will discuss this with my teammates and see what they think.

[brandyscarney]

Thanks for the issue! This was actually changed recently to use ion-page again, but it was adding the class as PascalCase. I've fixed it for the beta 10 release and created a nightly if you'd like to test it out:

npm install --save  [email protected]

Thanks again! 😄

[jasonwaters]

Thanks @brandyscarney! I tried out the nightly but it looks like there's a problem with ion-navbar not showing up now. I'm going to stick with beta.8 until 10 comes out. 😀

[brandyscarney]

@jasonwaters Oh yes we've changed a bit of the structure. We'll have some steps to upgrade to beta 10 in the changelog! 😊

[michael-brade]

@brandyscarney Heh, the code didn't take long to disappear again I guess. On Jun 28, this commit 215c6d8#diff-7b81c66d6f3e9c4b82c40ee5ecd30e50
deleted your fix (in fact, the whole loadComponent function), and now with Ionic 2 RC0 we are back to no class name in a modal. Would you mind adding it again? 😊