Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-datetime produces invalid ISO-8601 date format #6608

Closed
keithdmoore opened this issue May 22, 2016 · 8 comments
Closed

ion-datetime produces invalid ISO-8601 date format #6608

keithdmoore opened this issue May 22, 2016 · 8 comments
Assignees
Labels
needs: reply the issue needs a response from the user
Milestone

Comments

@keithdmoore
Copy link
Contributor

keithdmoore commented May 22, 2016

Date produced from Ionic2 (beta7) ion-datetime component looks like this:
"2016-01-02T01:00:00-aN:aN"

  <ion-item>
    <ion-label stacked>Date</ion-label>
    <ion-datetime displayFormat="MMM DD, YYYY HH:mm" [(ngModel)]="myDate"></ion-datetime>
  </ion-item>

Looks as though it is adding invalid characters -aN:aN at the end of the date string. Tested in Chrome and Firefox only.

Also, note the value in the UI is not placed under the "stacked" label. That should be a separate issue though.

http://plnkr.co/edit/KUengxqzfnRqm8pwIMSp?p=preview

Cordova CLI: 6.1.1
Gulp version: CLI version 3.9.1
Gulp local: Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.7
Ionic CLI Version: 2.0.0-beta.25
Ionic App Lib Version: 2.0.0-beta.15
ios-deploy version: 1.8.5
ios-sim version: 3.1.1
OS: Mac OS X El Capitan
Node Version: v5.8.0
Xcode version: Xcode 7.3.1 Build version 7D1014

@keithdmoore
Copy link
Contributor Author

@jgw96 Can you remove the ios label and add the datetime label on this one?

@keithdmoore
Copy link
Contributor Author

@adamdbradley Can you fix this? This is a REAL problem. Also, lots of styling issues with the datetime component. Label gets bolder for some reason. Date output does not go directly under stacked label. Hopefully you will get all that cleaned up so this component is usable.

@adamdbradley adamdbradley self-assigned this Jun 1, 2016
@adamdbradley adamdbradley added this to the 2.0.0-beta.8 milestone Jun 1, 2016
@adamdbradley
Copy link
Contributor

@keithdmoore Cool thanks for the report, should be all fixed up in the next release. Thanks!

@keithdmoore
Copy link
Contributor Author

@adamdbradley Should I create another issue for the cosmetic issues related to the datetime component or have you already addressed those? Thanks for all the great work you guys are doing!

@keithdmoore
Copy link
Contributor Author

keithdmoore commented Jun 12, 2016

The date is a valid date now but it is incorrect. Please reopen.

Expected: 2016-06-12T02:40:00Z
LOCAL is: Sat, 11 Jun 2016 21:40:00 -05:00

Actually got: 2016-06-11T21:40:00Z
LOCAL is: Sat, 11 Jun 2016 16:40:00 -05:00

Cordova CLI: 6.1.1
Gulp version: CLI version 3.9.1
Gulp local: Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.8-201606091959
Ionic CLI Version: 2.0.0-beta.25
Ionic App Lib Version: 2.0.0-beta.15
ios-deploy version: 1.8.5
ios-sim version: 3.1.1
OS: Mac OS X El Capitan
Node Version: v5.8.0
Xcode version: Xcode 7.3.1 Build version 7D1014

@keithdmoore
Copy link
Contributor Author

@jgw96 @danbucholtz please reopen.

@jgw96 jgw96 reopened this Jun 12, 2016
@jgw96
Copy link
Contributor

jgw96 commented Jun 12, 2016

Hey @keithdmoore, would you mind making a plunker that demonstrates the new issue? Thanks!

@jgw96 jgw96 added the needs: reply the issue needs a response from the user label Jun 12, 2016
@jgw96
Copy link
Contributor

jgw96 commented Jun 16, 2016

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!

@jgw96 jgw96 closed this as completed Jun 16, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

No branches or pull requests

4 participants