Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button and button-default class wrongly added to toggle #6237

Closed
jgw96 opened this issue Apr 19, 2016 · 1 comment
Closed

Button and button-default class wrongly added to toggle #6237

jgw96 opened this issue Apr 19, 2016 · 1 comment
Assignees
@brandyscarney
Milestone
2.0.0-beta.5

Comments

@jgw96
Copy link
Contributor

jgw96 commented Apr 19, 2016

Short description of the problem:

The button and button-default classes are getting added to the toggle when they shouldn't be.

What behavior are you expecting?

Steps to reproduce:

  1. Pull conf app and update to nightly
  2. Serve or run on a device

Which Ionic Version? 2.x latest nightly
@jgw96 jgw96 added v2 labels Apr 19, 2016
@brandyscarney
Copy link
Member

brandyscarney commented Apr 19, 2016 •
edited
Loading

Can see the UI damage on Android at http://localhost:8000/dist/e2e/toggle/basic/

@brandyscarney brandyscarney reopened this Apr 19, 2016
brandyscarney added a commit that referenced this issue Apr 20, 2016
@brandyscarney
fix(button): add a category to buttons so they won't get the button s…
35dd0ed 
…tyles

fixes #6237
@brandyscarney brandyscarney added this to the 2.0.0-beta.5 milestone Apr 20, 2016
@brandyscarney brandyscarney self-assigned this Apr 20, 2016
brandyscarney added a commit that referenced this issue Apr 20, 2016
@brandyscarney
fix(alert): remove justify content from buttons in an alert
9412a7c 
references #6237
brandyscarney added a commit that referenced this issue Apr 20, 2016
@brandyscarney
fix(button): remove classes from buttons with categories
5f8edc2 
references #6237
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.5
Development

No branches or pull requests
2 participants
@brandyscarney @jgw96