Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ion-img performance #6112

Closed
adamdbradley opened this issue Apr 11, 2016 · 2 comments
Closed

Improve ion-img performance #6112

adamdbradley opened this issue Apr 11, 2016 · 2 comments
Assignees
@adamdbradley
Milestone
2.0.0-beta.5

Comments

@adamdbradley
Copy link
Contributor

Safari has troubles cancelling image requests with the img src changes. Manually handle image HTTP requests, rather than letting <img> attempt to handle this.
@adamdbradley adamdbradley self-assigned this Apr 11, 2016
@adamdbradley adamdbradley added this to the 2.0.0-beta.5 milestone Apr 11, 2016
@adamdbradley adamdbradley mentioned this issue Apr 11, 2016
Closed
@manucorporat
Copy link
Contributor

@adamdbradley do you think we should fill a bug report in safari/webkit as well?

adamdbradley added a commit that referenced this issue Apr 11, 2016
@adamdbradley
perf(img): do not reuse img elements
b744275 
Safari UIWebView has troubles dropping image requests when the src
changes, and when there are hundreds going in and out this causes
issues. Instead, do not reuse img elements. Closes #6112
@adamdbradley
Copy link
Contributor Author

This is largely only a UIWebView problem, so I guess they kind of did fix it in WKWebView. The new way will not reuse the same img element, so it does a better job at aborting image requests.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adamdbradley adamdbradley

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.5
Development

No branches or pull requests
2 participants
@manucorporat @adamdbradley