Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The has-icon class is being added to tabs even if tabbarLayout is set to hide them #5658

Closed
brandyscarney opened this issue Feb 29, 2016 · 0 comments
Closed

The has-icon class is being added to tabs even if tabbarLayout is set to hide them #5658

brandyscarney opened this issue Feb 29, 2016 · 0 comments
Assignees
@brandyscarney
Milestone
2.0.0-beta.3

Comments

@brandyscarney
Copy link
Member

Tabbar number 7 here: http://localhost:8000/dist/e2e/tabs/tab-bar-scenarios/

It has tabbarLayout='icon-hide' on the ion-tabs component but the .tab-button is getting the .has-icon class.
@brandyscarney brandyscarney added this to the 2.0.0-beta.3 milestone Mar 1, 2016
brandyscarney added a commit that referenced this issue Mar 4, 2016
@brandyscarney
fix(tabs): don't add the has-icon class to a tab button if the layout…
6b93bc1 
… is icon-hide

fixes #5658
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.3
Development

No branches or pull requests
2 participants
@brandyscarney @Ionitron