Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add (cancel) event to ion-select #5439

Closed
BlackFoks opened this issue Feb 12, 2016 · 0 comments
Closed

feat: Add (cancel) event to ion-select #5439

BlackFoks opened this issue Feb 12, 2016 · 0 comments
Assignees
@adamdbradley
Milestone
2.0.0-beta.1

Comments

@BlackFoks
Copy link

Type: feat

Ionic Version: 2.x

Platform: all

At the moment ion-select has only (change) event that is fired when user clicks "OK" button. It would be useful to have (cancel) event for "Cancel" button as well.

This way any additional logic can be added to select pop-up, like this "Clear" button:

<ion-select cancelText="Clear" (cancel)="clearSelectInput()">

screenshot 2016-02-12 19 06 09

If it's acceptable I would like to implement it and send a PR, just let me know.
@BlackFoks BlackFoks changed the title feat: Add (cancel) event to select feat: Add (cancel) event to ion-select Feb 12, 2016
@brandyscarney brandyscarney added this to the 2.0.0-beta.1 milestone Feb 12, 2016
adamdbradley added a commit that referenced this issue Feb 13, 2016
@adamdbradley
feat(select): cancel output event
6a7c97d 
Closes #5439
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adamdbradley adamdbradley

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.1
Development

No branches or pull requests
4 participants
@BlackFoks @adamdbradley @brandyscarney @Ionitron