Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-item a-tag rendering issue #3497

Closed
frkris opened this issue Apr 10, 2015 · 5 comments
Closed

bug: ion-item a-tag rendering issue #3497

frkris opened this issue Apr 10, 2015 · 5 comments
Assignees

Comments

@frkris
Copy link

frkris commented Apr 10, 2015

Type: bug

Platform: all

I believe there is in an issue with using ng-href on ion-item together with angular html5 mode.

target="_self" in angular will cause a postback, rather than the intended SPA behavior.

Considering the below:

$scope.$target = function() {
return $attrs.target || '_self';
};

Target will always be set to self. There is no way to cause this item to be omitted.

Someone correct me if I am wrong, but it seems the correct behavior should be not to set it at all if it is not set on ion-item?

@frkris frkris changed the title ion-item a-tag rendering issue bug: ion-item a-tag rendering issue Apr 10, 2015
@mhartington
Copy link
Contributor

Would you be able to provide a codepen showing this?

@mhartington mhartington self-assigned this Apr 10, 2015
@mhartington mhartington added needs: reply the issue needs a response from the user navigation labels Apr 10, 2015
@frkris
Copy link
Author

frkris commented Apr 12, 2015

http://codepen.io/frkris/full/yydrOW/

Notice the difference in output between ng-repeat on an ion-item vs. a standard tag.

@Ionitron Ionitron removed the needs: reply the issue needs a response from the user label Apr 12, 2015
@mhartington
Copy link
Contributor

Hmm seeing this too. Will pass this to @adamdbradley

@adamdbradley adamdbradley added the needs: reply the issue needs a response from the user label Apr 15, 2015
@adamdbradley
Copy link
Contributor

Ahh ok, I see the issue now, fixing....

@adamdbradley adamdbradley removed the needs: reply the issue needs a response from the user label Apr 15, 2015
@frkris
Copy link
Author

frkris commented Apr 15, 2015

Thanks for the quick response guys! Much obliged!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants