Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroller doesn't scroll down enough for input #314

Closed
lingz opened this issue Dec 11, 2013 · 8 comments
Closed

Scroller doesn't scroll down enough for input #314

lingz opened this issue Dec 11, 2013 · 8 comments
Milestone
0.9.24

Comments

@lingz
Copy link

lingz commented Dec 11, 2013

screenshot_2013-12-11-23-33-11

The scroller in content doesn't go far down enough to see the input field that I am trying to enter into.
@mlynch
Copy link
Contributor

mlynch commented Dec 11, 2013

Ah, thanks for the screenshot. I think I know what the issue is. I'll see about fixing it.

@lingz
Copy link
Author

lingz commented Dec 12, 2013

I need to push this app for an alpha preview, do you mind sharing what you think the issue might be so I can hack around it for now? Thanks.

@ghost ghost assigned mlynch Dec 13, 2013
@mlynch
Copy link
Contributor

mlynch commented Jan 16, 2014

Hey @lingz, sorry about not getting back, vacation and all of that took us out of working for a bit. Is this issue still happening?

@lingz
Copy link
Author

lingz commented Jan 16, 2014

Sorry, haven't had time to update to the latest with the refactoring. Will
check soonish.

On Thu, Jan 16, 2014 at 10:03 PM, Max Lynch [email protected]:

Hey @lingz https://github.com/lingz, sorry about not getting back,
vacation and all of that took us out of working for a bit. Is this issue
still happening?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/314#issuecomment-32546577
.

@adamdbradley adamdbradley assigned ajoslin and unassigned mlynch Feb 3, 2014
@adamdbradley adamdbradley added this to the 0.9.24 milestone Feb 3, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Feb 10, 2014

Possibly related to #450.

After some intense searching, finally tracked this down to some reported bugs with Android WebView and fullscreen.

https://issues.apache.org/jira/browse/CB-4404
https://code.google.com/p/android/issues/detail?id=5497

So to fix until the issues are resolved, we could:

  • Remove fullscreen for android
  • See if we can hide the status bar without making the app fullscreen through some android preference
  • Now that we don't have fullscreen, Android will resize the window every time the keyboard opens. We can catch cordova's showkeyboard and hidekeyboard events (sent to the document) now.
  • Whenever the showkeyboard event is shown, we could hide all footers/bottombars/tabbars (since they will get moved up with the android-keyboard-window-resize). This could be easy if we just add a .hide-footers or the like css class to body.

ajoslin added a commit that referenced this issue Feb 12, 2014
@ajoslin
fix(android): when keyboard comes up, ensure input is in view
54830ac 
This requires us to set fullscreen="false" in our cordova apps.

Uses the resize event to determine when the keyboard has been shown,
then broadcasts an event from the activeElement 'scrollChildIntoView',
which is caught by the nearest parent scrollView.  The scrollView will
then see if that element is within the new device's height (since the
keyboard resizes the screen), and if not scroll it into view.

Additionally, when the keyboard resizes the screen we add a
`.hide-footers` class to the body, which will hide tabbars and footer
bars while the keyboard is opened.

For now, this is android only.

Closes #314.
@ajoslin ajoslin mentioned this issue Feb 12, 2014
Closed
@abarriere
Copy link

I have this issue with ionic 0.9.26 and android 4.3.
my configuration is :
www/config.xml :
www/index.html :

I have nothing special on controler or dependencies.
Did i miss something in my configuration ?

@abarriere abarriere mentioned this issue Feb 27, 2014
Closed
@mdsEu
Copy link

mdsEu commented Jun 10, 2015

the bug persists in ios?

@quedicesebas
Copy link

Why the cordova issue appears resolver? https://issues.apache.org/jira/browse/CB-4404

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.24
Development

Successfully merging a pull request may close this issue.

fix(android): when keyboard comes up, ensure input is in view ionic-team/ionic-framework
7 participants
@mlynch @adamdbradley @ajoslin @quedicesebas @lingz @abarriere @mdsEu