Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for error described on forum #1721

Closed
wants to merge 1 commit into from
Closed

Conversation

rysi3k
Copy link

@rysi3k rysi3k commented Jul 3, 2014

@perrygovier
Copy link
Contributor

Hey @rysi3k thanks for the PR.

Could you provide a working example in codepen demonstrating what this fixes?

Changes to tap.js are very treacherous, so we want to very cautious about adding this in. We'll definitely want to add unit tests to demonstrate the problem and that that this fixes it. Also, is there a way this can be done without an !important CSS flag?

@ajoslin
Copy link
Contributor

ajoslin commented Jul 7, 2014

This looks good to me. Problems this fixes:

  • The !important flag is needed when the original input has for example a position: static on it
  • We are sure to match the style of the original input
  • We are sure to match the classNames on the original input

I'll pull this down and test it out.

@ajoslin ajoslin closed this in 5da1ecd Jul 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: reply the issue needs a response from the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants