Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input file click not working when wrapped with label in ion-content #1699

Closed
saravmajestic opened this issue Jun 30, 2014 · 6 comments
Closed
Assignees

Comments

@saravmajestic
Copy link

Hi,

I am trying to create a file upload button with label wrapping input file. But clicking the label does not trigger the file upload popup.

Codepen: http://codepen.io/anon/pen/ArsCq

Thanks,
Saravanan

@perrygovier
Copy link
Contributor

Thanks @saravmajestic, this appears to be a problem with our fast buttons implementation that's preventing it. I'll work on a fix. In the meantime, adding data-tap-disabled="true" to your label corrects the issue.

@perrygovier perrygovier self-assigned this Jul 1, 2014
@saravmajestic
Copy link
Author

Awesome. Thanks @perrygovier . I tried with data-tap-disabled="true" and it works for me. Thanks again.

@perrygovier
Copy link
Contributor

Update, I have a proper fix ready, but I'd like to hold off on committing it until a new beta is released so it can sit in the nightlies for a while before making it to a beta.

@saravmajestic
Copy link
Author

Thanks a lot for the quick fix @perrygovier . I will wait for the next beta build and will verify it.

@perrygovier
Copy link
Contributor

Hey @saravmajestic, We just released a new beta, so I applied this fix. Because tap/click changes can be a bit treacherous, I deliberately left it out of today's beta, but it should be in the nightly build in an hour or two. Take it for a spin and let me know.

@eweap
Copy link

eweap commented Jan 22, 2015

Hi ! It seems that this bug is persisting in v1.0.0-beta.14-nightly-963, here is an example

Any ideas for a workaround ? I've tried to add data-tap-disabled="true" on the label but it didn't work.

Thanks

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants