Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware back button not disabled while loading overlay is active #1273

Closed
gouegd opened this issue May 5, 2014 · 4 comments
Closed

Hardware back button not disabled while loading overlay is active #1273

gouegd opened this issue May 5, 2014 · 4 comments

Comments

@gouegd
Copy link

gouegd commented May 5, 2014

This issue is related to #1222 (which was fixed and closed).

The Android hardware back button navigates back while the loading overlay (from $ionicLoading) is displayed.
Personally I avoid this by making the back button close the loading (I use promises to know it's been closed or not), but in some cases it could be better to just ignore the back button.

Ideally I think there would be a sensible default (no action ?), and the possibility the add one's own callback.

What do you think ?

@ajoslin
Copy link
Contributor

ajoslin commented May 5, 2014

Sounds good, adding.

@ajoslin
Copy link
Contributor

ajoslin commented May 5, 2014

Added!

@ajoslin ajoslin closed this as completed in fc8711c May 5, 2014
@gouegd
Copy link
Author

gouegd commented May 6, 2014

Great, thanks ! I can see in the code there's now a noop for the back button.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants