Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Scroll Component not being destroyed when displayed in Modal Component #10778

Closed
BradyNadeau opened this issue Mar 15, 2017 · 2 comments
Assignees

Comments

@BradyNadeau
Copy link

Ionic version: (check one with "x")
[ ] 1.x
[x] 2.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Description:
Virtual Scroll component not being destroyed when being presented inside a Modal.

Expectation:
Proper deletion and un-referencing of component

Steps to reproduce:

  1. Take a heap snapshot to compare with.
  2. Open a modal with a Virtual Scroll component inside the modal.
  3. Dismiss the modal. *repeat steps 2 & 3 a few times
  4. Take a Heap Snapshot and compare with your first and realize the additional Virtual Scroll Components that remain in memory.

I created an example below in plnkr:
http://plnkr.co/edit/8egskJTVU7IRcylj7TEm?p=preview
ezgif com-video-to-gif 2

I've been struggling to find the root cause of this issue and have failed to find a fix for it.. So before I head home for the day, I've chosen to let the community and DriftyCo to take a crack at it.

@manucorporat manucorporat self-assigned this Mar 15, 2017
@BradyNadeau
Copy link
Author

You're awesome for getting this fixed so fast! Thank you so much @manucorporat

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants