Allowed a tab-title to be watched #1071
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @graemefoster, thanks for the PR. You helped me realize the true issue: that the tab-nav element was never actually getting the un-interpolated version of the Anyway, it's fixed now! |
|
Cool - I see how you did it - moving the element creation to the compile phase instead of the link phase. Cheers, Graeme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if there is a better way (tried using observes and watches and I can't get it to work), but we have a requirement to allow the title of a tab to change - internal language service - and the current ion-tab-nav doesn't do this.
I've changed the binding to two-way and it works...