Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slides break when setting platform in query param #10577

Closed
mhartington opened this issue Feb 27, 2017 · 1 comment · Fixed by #10579
Closed

Slides break when setting platform in query param #10577

mhartington opened this issue Feb 27, 2017 · 1 comment · Fixed by #10579
Assignees
Milestone

Comments

@mhartington
Copy link
Contributor

Ionic version: (check one with "x")
[ ] 1.x
[x ] 2.x

I'm submitting a ... (check one with "x")
[ x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:
Setting ionicPlatform=android breaks click events in our slides docs demo.
Seems to be related to the rc5 refactor.

@mhartington mhartington self-assigned this Feb 27, 2017
mhartington added a commit that referenced this issue Feb 27, 2017
Slide fail to swipe when platform via query params.
This lets touch events be simulated is ionicPlatform is set.
Closes #10577
@manucorporat manucorporat added this to the 2.3.0 milestone Mar 15, 2017
manucorporat pushed a commit that referenced this issue Mar 15, 2017
* fix(slides): simulate touch events for query params
Slide fail to swipe when platform via query params.
This lets touch events be simulated is ionicPlatform is set.
Closes #10577

* style(remove debug log):
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 3, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants