Skip to content

Commit

Permalink
fix(tabs): invalid component comparison (#11084)
Browse files Browse the repository at this point in the history
getComponent() returns a ViewController, so we must reference the
component property when checking against the active component
  • Loading branch information
soumak77 authored and jgw96 committed Apr 17, 2017
1 parent 786de79 commit e423e08
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/tabs/tabs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ export class Tabs extends Ion implements AfterViewInit, RootNode {
});
} else {
getComponent(this._linker, tab.root).then(viewController => {
if (viewController !== active.component) {
if (viewController.component !== active.component) {
// Otherwise, if the page we're on is not our real root
// reset it to our default root type
return tab.setRoot(tab.root);
Expand Down

0 comments on commit e423e08

Please sign in to comment.