Skip to content

Commit

Permalink
fix(select): Open select options on Android 2.3
Browse files Browse the repository at this point in the history
Closes #1298
  • Loading branch information
Adam Bradley committed May 8, 2014
1 parent 9e06a66 commit d839f4d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions js/views/scrollView.js
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ ionic.views.Scroll = ionic.views.View.inherit({
return;
}

if( ionic.tap.containsOrIsTextInput(e.target) ) {
if( ionic.tap.containsOrIsTextInput(e.target) || e.target.tagName === 'SELECT' ) {
// do not start if the target is a text input
// if there is a touchmove on this input, then we can start the scroll
self.__hasStarted = false;
Expand All @@ -698,7 +698,7 @@ ionic.views.Scroll = ionic.views.View.inherit({
return;
}

if( !self.__hasStarted && ionic.tap.containsOrIsTextInput(e.target) ) {
if( !self.__hasStarted && ( ionic.tap.containsOrIsTextInput(e.target) || e.target.tagName === 'SELECT' ) ) {
// the target is a text input and scroll has started
// since the text input doesn't start on touchStart, do it here
self.__hasStarted = true;
Expand Down

0 comments on commit d839f4d

Please sign in to comment.