fix(ionList): do not let option button click propagate to item

Addresses #1202
ionic-team · Apr 25, 2014 · a845ff3 · a845ff3
1 parent 634b397
commit a845ff3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/js/angular/directive/itemOptionButton.js b/js/angular/directive/itemOptionButton.js
@@ -41,6 +41,8 @@ return {
         itemCtrl.$element.append(itemCtrl.optionsContainer);
       }
       itemCtrl.optionsContainer.append($element);
+
+      $element.on('click', eventStopPropagation);
     };
   }
 };

diff --git a/js/angular/directive/ngClick.js b/js/angular/directive/ngClick.js
@@ -34,13 +34,13 @@ IonicModule
 }])
 
 .directive('ionStopEvent', function () {
-  function stopEvent(e) {
-    e.stopPropagation();
-  }
   return {
     restrict: 'A',
     link: function (scope, element, attr) {
-      element.bind(attr.ionStopEvent, stopEvent);
+      element.bind(attr.ionStopEvent, eventStopPropagation);
     }
   };
 });
+function eventStopPropagation(e) {
+  e.stopPropagation();
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -41,6 +41,8 @@ return { @@
             itemCtrl.$element.append(itemCtrl.optionsContainer);
           }
           itemCtrl.optionsContainer.append($element);
+          $element.on('click', eventStopPropagation);
         };
       }
     };
@@ Expand Down @@