feat(virtual-scroll): apply contain:strict to virtual scroll items

ionic-team · Nov 20, 2016 · 947780e · 947780e
1 parent a8002ce
commit 947780e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 14 deletions.
diff --git a/src/components/virtual-scroll/test/list/app-module.ts b/src/components/virtual-scroll/test/list/app-module.ts
@@ -6,18 +6,17 @@ import { IonicApp, IonicModule } from '../../../..';
   templateUrl: 'main.html'
 })
 export class E2EPage {
-  items: Array<{title: string, date: string}>;
+  items: Array<{title: string}>;
 
   constructor() {
     this.emptyList();
   }
 
   fillList() {
     this.items = [];
-    for (let i = 0; i < 59; i++) {
+    for (let i = 0; i < 500; i++) {
       this.items.push({
-        title: 'Item ' + i,
-        date: '23:' + (59 - i)
+        title: 'Item ' + i
       });
     }
   }

diff --git a/src/components/virtual-scroll/test/list/main.html b/src/components/virtual-scroll/test/list/main.html
@@ -20,16 +20,7 @@
  <ion-list [virtualScroll]="items">
 
   <ion-item text-wrap *virtualItem="let item" (click)="itemTapped($event, item)">
-
-    <ion-row class="item-row">
-      <ion-col class="item-title" width-80>
-        {{item.title}}
-      </ion-col>
-      <ion-col class="item-time" width-20>
-        {{item.date}}
-      </ion-col>
-    </ion-row>
-
+    {{item.title}}
   </ion-item>
 
 </ion-list>

diff --git a/src/components/virtual-scroll/virtual-scroll.scss b/src/components/virtual-scroll/virtual-scroll.scss
@@ -14,6 +14,8 @@
   left: 0;
 
   transition-duration: 0ms;
+
+  contain: strict;
 }
 
 .virtual-scroll .virtual-hidden {