fix(loading): prevent spinners in loading view from causing reflows w…

…hen hidden. Closes #2013
ionic-team · Sep 17, 2014 · 767ce6a · 767ce6a
1 parent bcfecb4
commit 767ce6a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/js/angular/service/loading.js b/js/angular/service/loading.js
@@ -54,7 +54,7 @@ var LOADING_SET_DEPRECATED = '$ionicLoading instance.setContent() has been depre
  */
 IonicModule
 .constant('$ionicLoadingConfig', {
-  template: '<i class="ion-loading-d"></i>'
+  template: '<i class="icon ion-loading-d"></i>'
 })
 .factory('$ionicLoading', [
   '$ionicLoadingConfig',

diff --git a/scss/_loading.scss b/scss/_loading.scss
@@ -21,6 +21,9 @@
   visibility: hidden;
   opacity: 0;
 
+  &:not(.visible) .icon {
+    display: none;
+  }
   &.visible {
     visibility: visible;
   }

diff --git a/test/html/loading.html b/test/html/loading.html
@@ -19,7 +19,7 @@
       .controller('LoadingCtrl', function($scope, $ionicLoading) {
         $scope.startLoading = function() {
           $ionicLoading.show({
-            template: '<div>Connection problem.</div><br/><div>Please check your internet connection!</div>',
+            //template: '<div>Connection problem.</div><br/><div>Please check your internet connection!</div>',
             delay: 100,
             duration: 3000
           });