fix(popup): Backwards compatible remove popup from DOM, closes #851

ionic-team · Mar 31, 2014 · 441a21c · 441a21c
1 parent bfcf265
commit 441a21c
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 2 deletions.
diff --git a/js/ext/angular/src/service/ionicPopup.js b/js/ext/angular/src/service/ionicPopup.js
@@ -184,7 +184,7 @@ angular.module('ionic.service.popup', ['ionic.service.templateLoad'])
     popup.el.classList.add('popup-hidden');
 
     $timeout(function() {
-      popup.el.remove();
+      popup.el.parentNode.removeChild(popup.el);
     }, 400);
   };
 

diff --git a/js/ext/angular/test/popup.html b/js/ext/angular/test/popup.html
@@ -17,7 +17,42 @@
       <button class="button button-balanced" ng-click="showPrompt()">Prompt</button>
       <button class="button button-balanced" ng-click="showPasswordPrompt()">Password Prompt</button>
       <button class="button button-positive" ng-click="showAlert()">Alert</button>
-      <div style="height: 3000px; width: 50px; background-color: rgba(0,0,0,0.5);"></div>
+      <div class="list">
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+        <a class="item" href="#">Item</a>
+      </div>
     </ion-content>
 
     <script id="popup-template.html" type="text/ng-template">