fix(item): encode hex value in the detail arrow so it works on firefox

fixes #6830
ionic-team · Jun 9, 2016 · 03986d4 · 03986d4
1 parent 8350df0
commit 03986d4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/components/item/item.ios.scss b/src/components/item/item.ios.scss
@@ -13,7 +13,7 @@ $item-ios-note-color:                     darken($list-ios-border-color, 10%) !d
 
 $item-ios-detail-push-show:               true !default;
 $item-ios-detail-push-color:              $list-ios-border-color !default;
-$item-ios-detail-push-svg:               "<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 12 20'><path d='M2,20l-2-2l8-8L0,2l2-2l10,10L2,20z' fill='#{$item-ios-detail-push-color}'/></svg>" !default;
+$item-ios-detail-push-svg:                "<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 12 20'><path d='M2,20l-2-2l8-8L0,2l2-2l10,10L2,20z' fill='#{$item-ios-detail-push-color}'/></svg>" !default;
 
 $item-ios-divider-background:             #f7f7f7 !default;
 $item-ios-divider-color:                  #222 !default;

diff --git a/src/util/functions.scss b/src/util/functions.scss
@@ -119,7 +119,9 @@
 // --------------------------------------------------
 
 @function url-encode($val) {
-  @return str-replace($val, " ", "%20");
+  $spaces: str-replace($val, " ", "%20");
+  $encoded: str-replace($spaces, "#", "%23");
+  @return $encoded;
 }