Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(diagnostic): corrects isEnabled functions to isAvailable #373

Merged
merged 1 commit into from
Jul 31, 2016

Conversation

amuramoto
Copy link
Contributor

  • Location, camera, wifi, and bluetooth 'isEnabled' functions are incorrect. Corrected all to 'is Available'.

- Location, camera, wifi, and bluetooth 'isEnabled' functions are incorrect. All should be is Available.
@amuramoto
Copy link
Contributor Author

Fixes #365

@ihadeed
Copy link
Collaborator

ihadeed commented Jul 31, 2016

Hey there,

Thanks for the PR.

The methods shouldn't be replaced. The plugin actually exports both isLocationAvailable and isLocationEnabled.

The current implementation of the plugin is just missing many of the functions listed here: https://www.npmjs.com/package/cordova.plugins.diagnostic

Related: #224

@ihadeed ihadeed closed this Jul 31, 2016
@ihadeed ihadeed reopened this Jul 31, 2016
@ihadeed
Copy link
Collaborator

ihadeed commented Jul 31, 2016

Just checked the docs again, you're right these should be Available instead of Enabled. But we will still be missing the Enabled functions for now.

Thanks again!

@ihadeed ihadeed merged commit ccf7fb5 into danielsogl:master Jul 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants