Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uncrossArbBot changes and improvements #83

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

uncrossArbBot changes and improvements #83

wants to merge 6 commits into from
+85 −46

Conversation

ricardojmendez
Copy link
Contributor

A couple of small changes:

  • It was ignoring the dryRun option, implemented;
  • Added priority fees;
  • Removed unused imports.

@ricardojmendez
BUGFIX: uncrossArbBot was not obeying dry run setting
050c83d
@ricardojmendez
Removed unused imports from uncrossArbBot
9dba735
@ricardojmendez
Removed exception dump on NoArbOpportunity
927d770 
The client is already logging it, there's no need to do it twice.

Also updated the error log, since there was a double negative.
@ricardojmendez
Adding priority fees to uncrossArbBot
f4d28f5
@ricardojmendez
Fixed noArbOpError logging
04129c7 
It wasn't logging the errors in the case where there were logs BUT
it hadn't been a noArbOpError.
@ricardojmendez
Added optional fee multiplier to uncrossArbBot
74b8847
@ricardojmendez
Copy link
Contributor Author

Two more additions:

  • Fixed an issue with noArbOpError logging
  • Added an optional fee multiplier, in case people want to skip cases that are too tight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ricardojmendez