Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danfoss eTRV0100 thermostat missing mandatory SystemMode (0x001C) attribute in json api #6641

Closed
danieldemus opened this issue Jan 2, 2023 · 2 comments

Comments

@danieldemus
Copy link

Describe the bug

The following json response from a Danfoss Ally eTRV0100 thermostat should contain a "mode" attribute containing "off" or "heat".

{
    "config": {
        "battery": 63,
        "displayflipped": false,
        "externalsensortemp": -8000,
        "externalwindowopen": false,
        "heatsetpoint": 2000,
        "locked": false,
        "mountingmode": false,
        "offset": 0,
        "on": true,
        "reachable": true,
        "schedule": {},
        "schedule_on": false
    },
    "ep": 1,
    "etag": "b735466c24b7cd120b4bf45b595cd4ae",
    "lastannounced": null,
    "lastseen": "2023-01-02T19:21Z",
    "manufacturername": "Danfoss",
    "modelid": "eTRV0100",
    "name": "Thermostat, Stue højre",
    "state": {
        "errorcode": "0",
        "lastupdated": "2023-01-02T18:30:21.028",
        "mountingmodeactive": false,
        "on": true,
        "temperature": 1997,
        "valve": 25,
        "windowopen": "Quarantine"
    },
    "swversion": "01.18.0008 01.18",
    "type": "ZHAThermostat",
    "uniqueid": "0c:43:14:ff:fe:c7:1c:27-01-0201"
}

Steps to reproduce the behavior

Observe in deconz that the thermostat has a value for the 0x0201 cluster 0x001C attribute.
Using the phoscon app get the a json response for a eTRV0100.
Observe the lack of such a value in the json response.

Expected behavior

There is a "mode" attribute matching the value in the 0x0201 Thermostat cluster for 0x001C System mode.

Screenshots

This is the relevant part of the cluster info for one of the thermostats
image

Environment

  • Host system: Raspberry Pi
  • Running method: Raspbian
  • Firmware version: 26720700
  • deCONZ version: 2.19.03
  • Device: ConBee II
  • Do you use an USB extension cable: yes
  • Is there any other USB or serial devices connected to the host system? no

deCONZ Logs

HTTP logs the above json response.

Additional con

deconz-rest-plugin/devices/danfoss/etrv0100_thermostat.json doesn't include "config/mode" in it's items, thermostat.json does.

@SwoopX
Copy link
Collaborator

SwoopX commented Jan 2, 2023

The reason not to include that attribute is that it is pointless to expose something which only allows for a single value, heat. In other words: there are no other valid values than heat.

@SwoopX SwoopX closed this as completed Jan 2, 2023
@danieldemus
Copy link
Author

danieldemus commented Jan 3, 2023

It's a mandatory attribute that is expected by json consumers to be there. Fx. the openhab deconz plugin expects it, so all danfoss thermostats are always in the unknown state.
All the mandatory attributes from the zigbee specification should be exported in the json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants