Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to manifest v3 #112

Open
dreamos82 opened this issue Aug 17, 2021 · 5 comments
Open

Switch to manifest v3 #112

dreamos82 opened this issue Aug 17, 2021 · 5 comments

Comments

@dreamos82
Copy link
Owner

A new version of the manifest has been released, need to decide if is worth for now switching to the new version (also need to check with firefox too)

https://developer.chrome.com/docs/extensions/mv3/intro/

@dreamos82 dreamos82 added this to the 1.8 milestone Dec 2, 2021
@dreamos82
Copy link
Owner Author

Looks like it will become mandatory in the future and v2 is going to be phaased out, so i'll add this to next milestone.

@dreamos82
Copy link
Owner Author

The upgrade from manifest v2 to v3 is one of the most painful process, basically most of the stuff previously used became deprecated or unavailabe, or totally different to use.

It will require lot of code changes. Hoping to avoid a full rewrite!

@dreamos82
Copy link
Owner Author

dreamos82 commented Feb 8, 2022

Things to do:

  • Upgrade manifest version
  • Fix parsing
  • Fix import
  • Fix background scripts
  • check that it works on firefox too
  • fix help
  • check if all other buttons/links are working

@dreamos82
Copy link
Owner Author

The updates are mostly done and the extension works fine on chrome (can't find any major issue) but manifest v3 is not supported in firefox, so i need to figure out a way to differentiate the code.

@dreamos82
Copy link
Owner Author

Ok another update: unfortunately firefox doesn't support manifest v3 yet. So the only choice i had was to split the logic where the manifest v3 required different behaviour from v2, i'm testing the changes on both browser.

The only drawback that has this change is that now the manifest has to be split in 2, one for firefox and one for chrome, so for anyone that wants to use the extension from sources he/she will need to have an extra step of copying the correct manifest file into manifest.json according to the browser used.

Updates are in branch https://github.com/dreamos82/chrome_parameters/tree/112_manifest_v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant