Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to close remainig popover after deleting table #29

Conversation

haecheonlee
Copy link
Contributor

@haecheonlee haecheonlee commented Apr 11, 2024

Steps to reproduce

  1. Add multiple tables
  2. Click a table
  3. Click tertiary icon to show the popover
  4. Delete the first created table

Expected
The popover should be hidden

Actual
The popover is visible

Describe your changes

The change fixes to hide Popover in Table.jsx, because the component remains open after deleting an existing table. The approach is to assign unique key to each table and assign it to the component's key.

Copy link

vercel bot commented Apr 11, 2024

@haecheonlee is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

@haecheonlee haecheonlee marked this pull request as ready for review April 11, 2024 00:16
Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 4:29am

Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you

@1ilit 1ilit merged commit 2740aee into drawdb-io:main Apr 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants