Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dependencies; fixes start script; refactors to add push support. #1

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

colinbdclark
Copy link
Contributor

Hi @drart, this should make your application work a little more smoothly. The .npmrc file instructs npm on how to build your application against Electron rather than a standard Node.js runtime, without needing all of the electron-rebuild stuff.

Electron needs to know where your source code entry point is, hence the addition of a "main" option in package.json. I switched to using requestAnimationFrame so that your animation will be well-timed.

There are much newer versions of Electron, but I think it's safest to link to this older one temporarily until I can ensure the rest of the stack is compatible. It also sounds like Electron 12 is going to make some majorly backwards-incompatible changes to how it handles native modules, so I think it's wise to be conservative with updates until libraries have had time to be updated.

I don't have an Ableton Push, so I have no idea if this will actually work, but it should get you a little closer anyway.

@drart
Copy link
Owner

drart commented Dec 29, 2020

Thanks @colinbdclark! It works wonderfully!
On my Catalina machine I had to install the full Xcode, which seems to be an issue with node-gyp. (see nodejs/node-gyp#1927)

@drart drart closed this Dec 29, 2020
@drart drart reopened this Dec 29, 2020
@drart drart merged commit 553108b into drart:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants