Updates dependencies; fixes start script; refactors to add push support. #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @drart, this should make your application work a little more smoothly. The .npmrc file instructs npm on how to build your application against Electron rather than a standard Node.js runtime, without needing all of the electron-rebuild stuff.
Electron needs to know where your source code entry point is, hence the addition of a
"main"
option in package.json. I switched to usingrequestAnimationFrame
so that your animation will be well-timed.There are much newer versions of Electron, but I think it's safest to link to this older one temporarily until I can ensure the rest of the stack is compatible. It also sounds like Electron 12 is going to make some majorly backwards-incompatible changes to how it handles native modules, so I think it's wise to be conservative with updates until libraries have had time to be updated.
I don't have an Ableton Push, so I have no idea if this will actually work, but it should get you a little closer anyway.