Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive - strings with comments #20

Open
jamiehunt opened this issue Sep 19, 2021 · 1 comment
Open

False positive - strings with comments #20

jamiehunt opened this issue Sep 19, 2021 · 1 comment
Labels
question Further information is requested

Comments

@jamiehunt
Copy link

Strings with same-line comments appear to produce false missing violations
Partial Violation: Localized string "my_string" is missing in locale "ja" (partial)

en/Localizable.strings

"my_string" = "Foo bar...";

ja/Localizable.strings

"my_string" = "フーバー"; // Some comment
@dral3x
Copy link
Owner

dral3x commented Sep 27, 2021

Hi @jamiehunt !
Thanks for reporting this issue.

Are comments supposed to be added inline? I never saw them used like that inside a .strings. file.

@dral3x dral3x added the question Further information is requested label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants