Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single flight auth request in registry backend #890

Closed
changweige opened this issue Nov 23, 2022 · 2 comments
Closed

Single flight auth request in registry backend #890

changweige opened this issue Nov 23, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@changweige
Copy link
Contributor

It is observed that auth request is perform for multiple HTTP requests at the same time.

[2022-11-23 17:50:17.164761 +08:00] INFO [api/src/http.rs:911] http server started
[2022-11-23 17:50:17.180606 +08:00] INFO [storage/src/backend/registry.rs:228] cached bearer auth, next time: 1669198817
[2022-11-23 17:50:17.191378 +08:00] INFO [storage/src/backend/registry.rs:228] cached bearer auth, next time: 1669198817
[2022-11-23 17:50:17.191417 +08:00] INFO [storage/src/backend/registry.rs:228] cached bearer auth, next time: 1669198817
[2022-11-23 17:50:17.195609 +08:00] INFO [storage/src/backend/registry.rs:228] cached bearer auth, next time: 1669198817
[2022-11-23 17:50:17.201410 +08:00] INFO [storage/src/backend/registry.rs:228] cached bearer auth, next time: 1669198817
[2022-11-23 17:50:17.202158 +08:00] INFO [storage/src/backend/registry.rs:228] cached bearer auth, next time: 1669198817
[2022-11-23 17:50:17.204344 +08:00] INFO [storage/src/backend/registry.rs:228] cached bearer auth, next time: 1669198817
[2022-11-23 17:50:17.218468 +08:00] INFO [storage/src/backend/registry.rs:228] cached bearer auth, next time: 1669198817
[2022-11-23 17:50:17.252392 +08:00] INFO [storage/src/backend/registry.rs:228] cached bearer auth, next time: 1669198817
@imeoer imeoer added the good first issue Good for newcomers label Nov 30, 2022
@imeoer
Copy link
Collaborator

imeoer commented Dec 19, 2022 •
edited
Loading

Can we initiate a getting token auth request first (for example HEAD /v2/<name>/manifests/<reference>) ? Once the token is obtained, then send multiple blob requests.

@imeoer
Copy link
Collaborator

imeoer commented Sep 7, 2023

It should have been fixed in #1375.

@imeoer imeoer closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imeoer @changweige