nydusify: fix error in go vet

`sudo` in action will change go env, remove sudo. In runner user, we can create file in unpacktargz-test inseted of temp/unpacktargz-test, so don't use os.CreateTemp in archive_test.go. Signed-off-by: Yadong Ding <[email protected]>
dragonflyoss · Dec 25, 2023 · bd02185 · bd02185
1 parent 8d2f0e9
commit bd02185
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 21 deletions.
diff --git a/.github/workflows/smoke.yml b/.github/workflows/smoke.yml
@@ -193,7 +193,7 @@ jobs:
     - name: Unit Test
       run: |
         curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sudo sh -s -- -b /usr/bin v1.54.2
-        sudo make -e DOCKER=false contrib-test
+        make -e DOCKER=false contrib-test
     - name: Upload contrib coverage file
       uses: actions/upload-artifact@v3
       with:

diff --git a/contrib/nydusify/Makefile b/contrib/nydusify/Makefile
@@ -36,4 +36,4 @@ coverage: test
 
 clean:
 	rm -f cmd/nydusify
-	rm -f coverage.out
+	rm -f coverage.txt
diff --git a/contrib/nydusify/pkg/utils/archive_test.go b/contrib/nydusify/pkg/utils/archive_test.go
@@ -6,13 +6,10 @@
 package utils
 
 import (
-	"context"
-	"io"
 	"os"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 func TestPackTargzInfo(t *testing.T) {
@@ -29,19 +26,3 @@ func TestPackTargzInfo(t *testing.T) {
 	assert.Equal(t, "sha256:6cdd1b26d54d5852fbea95a81cbb25383975b70b4ffad9f9b6d25c7a434a51eb", digest.String())
 	assert.Equal(t, size, int64(315))
 }
-
-func TestUnpackTargz(t *testing.T) {
-	file, err := os.CreateTemp("", "nydusify-test")
-	defer os.RemoveAll(file.Name())
-	require.NoError(t, err)
-	err = os.WriteFile(file.Name(), []byte("123456789"), 0666)
-	require.NoError(t, err)
-	reader, err := PackTargz(file.Name(), file.Name(), true)
-	require.NoError(t, err)
-
-	err = UnpackTargz(context.Background(), "test", io.Reader(reader), false)
-	defer os.RemoveAll("test")
-	require.NoError(t, err)
-	err = UnpackTargz(context.Background(), "test", io.Reader(reader), true)
-	require.NoError(t, err)
-}