Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ut for containerd init #859

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

CormickKneey
Copy link
Contributor

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.17%. Comparing base (574f376) to head (63802b4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ly-client-init/src/container_runtime/containerd.rs 96.77% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
+ Coverage   32.64%   33.17%   +0.53%     
==========================================
  Files          57       57              
  Lines        8712     8774      +62     
==========================================
+ Hits         2844     2911      +67     
+ Misses       5868     5863       -5     
Files with missing lines Coverage Δ
...ly-client-init/src/container_runtime/containerd.rs 97.14% <96.77%> (+84.64%) ⬆️
---- 🚨 Try these New Features:

Signed-off-by: cormick <[email protected]>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 88b1f7e into dragonflyoss:main Nov 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants