Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change task and peer ttl #984

Merged
merged 1 commit into from
Jan 12, 2022
Merged

feat: change task and peer ttl #984

merged 1 commit into from
Jan 12, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Change task and peer TTL.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #984 (ceb05d8) into main (ffa6f3c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #984      +/-   ##
==========================================
- Coverage   45.66%   45.64%   -0.02%     
==========================================
  Files         131      129       -2     
  Lines        9036     9002      -34     
==========================================
- Hits         4126     4109      -17     
+ Misses       4443     4431      -12     
+ Partials      467      462       -5     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.64% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/config/config.go 0.00% <0.00%> (ø)
client/daemon/storage/local_storage.go 23.57% <0.00%> (-1.52%) ⬇️
client/clientutil/buffer.go
client/daemon/peer/piece_downloader_optimized.go
client/daemon/peer/peertask_conductor.go 53.13% <0.00%> (+0.05%) ⬆️
client/daemon/peer/piece_manager.go 66.05% <0.00%> (+0.63%) ⬆️

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero yxxhero merged commit ed14688 into main Jan 12, 2022
@yxxhero yxxhero deleted the feature/task-ttl branch January 12, 2022 10:00
gaius-qi added a commit that referenced this pull request Jan 12, 2022
gaius-qi added a commit that referenced this pull request Jan 17, 2022
* feat: change task and peer ttl (#984)

Signed-off-by: Gaius <[email protected]>

* feat: send error code

Signed-off-by: Gaius <[email protected]>

Signed-off-by: Gaius <[email protected]>

* feat: add retry interval

Signed-off-by: Gaius <[email protected]>

* feat: dfdaemon report successful piece before end of piece

Signed-off-by: Gaius <[email protected]>

* feat: update submodule version

Signed-off-by: Gaius <[email protected]>
gaius-qi added a commit that referenced this pull request Jun 28, 2023
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: change task and peer ttl (#984)

Signed-off-by: Gaius <[email protected]>

* feat: send error code

Signed-off-by: Gaius <[email protected]>

Signed-off-by: Gaius <[email protected]>

* feat: add retry interval

Signed-off-by: Gaius <[email protected]>

* feat: dfdaemon report successful piece before end of piece

Signed-off-by: Gaius <[email protected]>

* feat: update submodule version

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants