Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: dump goroutine in e2e #980

Merged
merged 1 commit into from
Jan 12, 2022
Merged

test: dump goroutine in e2e #980

merged 1 commit into from
Jan 12, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Jan 12, 2022

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner January 12, 2022 02:50
@jim3ma jim3ma force-pushed the test/dump-goroutine-in-e2e branch from 3b80176 to 3ccb6cb Compare January 12, 2022 02:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #980 (908d81c) into main (4c94a26) will increase coverage by 0.00%.
The diff coverage is 30.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #980   +/-   ##
=======================================
  Coverage   43.66%   43.67%           
=======================================
  Files         115      115           
  Lines        8542     8548    +6     
=======================================
+ Hits         3730     3733    +3     
- Misses       4349     4355    +6     
+ Partials      463      460    -3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 43.67% <30.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/proxy/proxy.go 9.80% <0.00%> (-0.13%) ⬇️
client/daemon/peer/peertask_manager.go 34.84% <33.33%> (-1.09%) ⬇️
client/daemon/peer/peertask_conductor.go 53.08% <100.00%> (ø)
pkg/sync/krwmutex.go 86.36% <0.00%> (+4.54%) ⬆️
pkg/sync/kmutex.go 100.00% <0.00%> (+16.66%) ⬆️

@jim3ma jim3ma force-pushed the test/dump-goroutine-in-e2e branch from 3ccb6cb to 908d81c Compare January 12, 2022 04:30
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit e48d626 into main Jan 12, 2022
@jim3ma jim3ma deleted the test/dump-goroutine-in-e2e branch January 12, 2022 05:53
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants