Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize get piece tasks log #974

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Optimize get piece tasks log #974

merged 1 commit into from
Mar 4, 2022

Conversation

244372610
Copy link
Contributor

Signed-off-by: sunwp [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: sunwp <[email protected]>
@244372610 244372610 requested a review from a team as a code owner January 5, 2022 04:04
@codecov-commenter
Copy link

Codecov Report

Merging #974 (ce1c389) into main (c9c3650) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #974      +/-   ##
==========================================
+ Coverage   42.31%   42.47%   +0.15%     
==========================================
  Files         116      116              
  Lines        8798     8798              
==========================================
+ Hits         3723     3737      +14     
+ Misses       4607     4598       -9     
+ Partials      468      463       -5     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 42.47% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_base.go 46.53% <0.00%> (+0.57%) ⬆️
client/daemon/peer/piece_manager.go 63.46% <0.00%> (+0.64%) ⬆️
client/daemon/peer/peertask_stream.go 55.41% <0.00%> (+1.85%) ⬆️
client/daemon/peer/peertask_stream_callback.go 64.07% <0.00%> (+1.94%) ⬆️
pkg/sync/krwmutex.go 86.36% <0.00%> (+4.54%) ⬆️

Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@244372610 244372610 merged commit ad29c4c into main Mar 4, 2022
@244372610 244372610 deleted the feature/choreCDNLog branch March 4, 2022 09:02
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants